Skip to content

Send string as bytes #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kosh04 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Send string as bytes #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions elnode.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1768,10 +1768,11 @@ return DEFAULT instead of `nil'."
(elnode--http-parse-status httpcon :elnode-http-version)))

(defun elnode-http-send-string (httpcon str)
"Send STR to HTTPCON, doing chunked encoding."
"Send STR as bytes to HTTPCON, doing chunked encoding."
(elnode-msg :debug
"elnode-http-send-string %s [[%s]]" httpcon (s-truncate 10 str))
(let ((len (string-bytes str)))
(let* ((bytes (encode-coding-string str 'binary))
(len (string-bytes bytes)))
(elnode/con-put httpcon :elnode-bytes-written
(+ len (or (elnode/con-get httpcon :elnode-bytes-written) 0)))
;; FIXME Errors can happen here, because the socket goes away.. it
Expand All @@ -1780,14 +1781,14 @@ return DEFAULT instead of `nil'."
(condition-case err
(process-send-string
httpcon
(format "%x\r\n%s\r\n" (length str) (or str "")))
(format "%x\r\n%s\r\n" len (or bytes "")))
(error
(elnode-msg :warning
"elnode-http-send-string failed to send [%s] on %s (%s)"
(length str) httpcon (process-status httpcon))))
len httpcon (process-status httpcon))))
(elnode-msg :warning
"elnode-http-send-string can't print [%s] because %s is %s"
(length str) httpcon (process-status httpcon)))))
len httpcon (process-status httpcon)))))

(defconst elnode-http-codes-alist
(loop for p in '((200 . "Ok")
Expand Down