Skip to content

Update attributes that should not be localized #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajsite merged 2 commits into from
Dec 16, 2025
Merged

Update attributes that should not be localized #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b53d34a
Update attributes that should not be localized
m-akinc Dec 16, 2025
893239c
Change files
m-akinc Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@ni-eslint-config-angular-9b8d79a3-e467-4e2b-8546-8eca3dd89d73.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update attributes that should not be localized",
"packageName": "@ni/eslint-config-angular",
"email": "7282195+m-akinc@users.noreply.github.com",
"dependentChangeType": "patch"
}
31 changes: 30 additions & 1 deletion packages/eslint-config-angular/lib/template-options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,21 @@ const ignoreAttributeSets = {
'aria-describedby',
'aria-labelledby',
'aria-live',
'form',
'rel',
'sizes',
// anchor
'hreflang',
'ping',
'referrerpolicy',
'download',
// Not possible for Angular i18n to handle meta tags yet
// https://github.com/angular/angular-cli/issues/8947
'meta[content]'
],
nimble: [
// shared
'alignment',
'appearance',
'appearance-variant',
'orientation',
Expand All @@ -37,6 +44,7 @@ const ignoreAttributeSets = {
'location',

// rich text
'markdown',
'nimble-mapping-user[display-name]',
'pattern',

Expand All @@ -57,9 +65,31 @@ const ignoreAttributeSets = {
'menu-slot',
'parent-id-field-name',
'selection-mode',
'sort-by-field-name',
'sort-direction',
'width-mode',

// table column (date-text)
'custom-locale-matcher',
'custom-weekday',
'custom-era',
'custom-year',
'custom-month',
'custom-day',
'custom-hour',
'custom-minute',
'custom-second',
'custom-time-zone-name',
'custom-format-matcher',
'custom-hour12',
'custom-time-zone',
'custom-calendar',
'custom-day-period',
'custom-numbering-system',
'custom-date-style',
'custom-time-style',
'custom-hour-cycle',

// tabs
'activeid',

Expand All @@ -75,7 +105,6 @@ const ignoreAttributeSets = {
// angular-specific
'nimbleRouterLink',
'queryParamsHandling'

],
spright: [
// chat
Expand Down