Skip to content

Conversation

@jfriedri-ni
Copy link
Contributor

What does this Pull Request accomplish?

Use human-readable strings for the installed software items, not the NIPM package name.

Why should this Pull Request be merged?

This PR makes the Python example code select the same contents as the LabVIEW example.

What testing has been done?

Python static analysis

  • nps lint
  • mypy

Hand testing

Running the example

> poetry run system

Scanning system for metadata...
Publishing detected system metadata...
Querying system metadata...

TestResult ID: c44409d8-294f-4a0a-8e58-6bf418d5eb83
- Operator: 28861705-58ba-4e49-b5f7-71e55cb0f1f5
- Test Station: 6e2ecc61-0991-454a-82ee-c302acde976a
- Installed Software: 118 packages
- Available Hardware: 12 devices

yields

image

in the SoftwareItem table.

Copilot AI review requested due to automatic review settings December 1, 2025 19:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the system example to use human-readable software product names instead of NIPM package identifiers, aligning the Python implementation with the LabVIEW system example behavior.

  • Changed create_software_item() to use software_entry.title instead of software_entry.id for the product field
  • Improves user experience by displaying readable product names (e.g., "LabVIEW") instead of internal package identifiers in the SoftwareItem table

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jfriedri-ni jfriedri-ni merged commit 9c6c36f into main Dec 2, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants