This repository was archived by the owner on Mar 2, 2018. It is now read-only.
Changes to improve currentTime method#195
Open
marpereira wants to merge 2 commits intong2-ui:masterfrom
Open
Conversation
|
When these changes will be merged? |
|
These changes are actually useful please merge. |
…ethod selectCurrentTime to use this two attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes will improve the method of
selectCurrentTime()in order to meet these use cases:When users click on
current Timebutton the result date not only needs to be present hour and minute but also year, month and day.At some business logic, developers want that when users click on
current Timebutton the result time needs to be atUTC.Developers could use this two use cases at same time. IE: When users click on
current Timebutton the result date not only needs to be present hour and minute inUTCbut also year, month and day (atUTC).