Add default profile to set Snakemake CLI args#13
Add default profile to set Snakemake CLI args#13corneliusroemer wants to merge 1 commit intomainfrom
Conversation
The special profile at `profiles/default/config.yaml` is used by snakemake >= 7.29 by default without requiring passing in via `--profile profiles/default` Profiles are nice because they reduce number of CLI args required when invoking `snakemake`
|
This prompted me to read more about Snakemake profiles. Good to know that the default profile can be unset with |
| @@ -0,0 +1,4 @@ | |||
| cores: all | |||
There was a problem hiding this comment.
The PR overall looks good to me, but I wonder if this should be cores: 1 to better reflect how the current tutorial instructions tell people to run things?
There was a problem hiding this comment.
I would think to not introduce the additional complexity of profiles here - we don't use use them for most pathogen repos.
If the goal is to remove the unnecessary --cores argument, we can already remove that - it's not required as of Nextstrain CLI 4.0.0.
|
This PR seems to have become Warnocked — can we either determine what changes are required to allow it to be merged, or close it out? |
|
I vote to close for the reasons Victor gave. |
The special profile at
profiles/default/config.yamlis used by snakemake >= 7.29 by default without requiring passing in via--profile profiles/defaultProfiles are nice because they reduce number of CLI args required when invoking
snakemake, e.g. one no longer needs to use--cores 1or-c1which became necessary in snakemake at some point.With the default profile, one can simply run the tutorial by typing
snakemake.