Draft
Conversation
The Mumps Nextclade dataset had been reporting both a "Clade" and a "MuV_genotype" column. This change only reports the "Clade" assignment as the second is redundant for the user. This change also allows us to drop the hard coded nextclade_extension specification in the auspice_config files since pathogen.json already has this information and having both would risk settings getting out of sync and confusion during debugging.
Add documentation on where clade_membership is being spiked in or inferred from a fall back column. Clearly use clade_membership during the genome filtering step, even though MuV_genotype should have equivalent behavior.
j23414
force-pushed
the
nextclade-drop-extra-column
branch
from
603d383 to
8d3a839
Compare
j23414
force-pushed
the
nextclade-drop-extra-column
branch
from
3015ddb to
448c6b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Since the genome Nextclade dataset has QC, initialized QC parameters for sh Nextclade dataset. However, I could use some help on picking thresholds...
Related issue(s)
Checklist