Use mean instead of median for point estimates#38
Merged
Conversation
Adds logic to parse a `ps_point_estimator` function name from the model config YAML and pass that estimator name to the evofr function for generating tidy data frames. This interface allows users to choose one of the available point estimates generated by evofr as the representative value to plot in evofr-viz and other downstream tools. Updates the configs for all three subtypes to use the "mean" instead of the "median" for reporting frequencies and GAs. Updates the local JSON parsing script to export mean along with median in the data frame output. Closes #32 Requires blab/evofr#65 Requires nextstrain/forecasts-viz#33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Adds logic to parse a
ps_point_estimatorfunction name from the model config YAML and pass that estimator name to the evofr function for generating tidy data frames. This interface allows users to choose one of the available point estimates generated by evofr as the representative value to plot in evofr-viz and other downstream tools.Updates the configs for all three subtypes to use the "mean" instead of the "median" for reporting frequencies and GAs. Updates the local JSON parsing script to export mean along with median in the data frame output.
Related issue(s)
Closes #32
Requires blab/evofr#65
Requires nextstrain/forecasts-viz#33
Checklist