Conversation
The bioconda recipe is borked. And the PR which added it is an amazing example of what not to do: deleting failing tests one-by-one just to get CI to pass and then merging without review. orz |
Can you elaborate? I'm not familiar enough with conda recipes to see what's wrong with it 😅 |
|
The recipe tells Bioconda how to build the Conda package, and it looks like the package we're getting was not built correctly. I'd guess that something in the |
|
Created an issue in bioconda-recipes: bioconda/bioconda-recipes#55914 |
@joverlee521 I would have, but I didn't look into how it's borked, but I did confirm the borkage. After its installed, for example, the Python libraries are not present in |
|
See my hacky fix in bioconda/bioconda-recipes#55920 |
Matching nextstrain/docker-base#248. Pin minimum version to 1.8.0 for NDJSON support.
victorlin
left a comment
There was a problem hiding this comment.
Didn't test (not easily testable on Hutch network), but looks good given bio was added by all 3 builds in @tsibley's manually triggered CI run:
name: bio
version: 1.8.0
build: pyhdfd78af_0
|
Thanks for following up here @tsibley 🙏 |
|
Since I was mucking around in this repo anyway, I figured I'd take care of this too. :-)
|

Description of proposed changes
Based on #108 to work-around CI hanging issues
Update:
biorecipe has been fixed in bioconda with bioconda/bioconda-recipes#55920. This PR is now only blocked on #105I wanted to add
bioto match docker-base since I found it on bioconda.Checklist