Add send and recv locations #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomMelt
force-pushed
the
use-perimeter-offset
branch
from
39d15d4 to
bd29ae4
Compare
joewallwork
approved these changes
Sep 18, 2025
Contributor
joewallwork
left a comment
joewallwork
left a comment
There was a problem hiding this comment.
Thanks @TomMelt, this looks like the right thing to do. There's a TODO note to finish the docs but otherwise ready to merge.
| /*! | ||
| * @brief Compute the start location of the halo for a given pair of neighbouring domains. | ||
| * | ||
| * TODO: This needs to be updated to reflect changes to halo start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NextSim halo logic needs to know which data to
sendand where to receive (recv) it. This PR adds those indices to the metadata output file whichdecompproduces and NextSim reads in.