Skip to content

feat(singleInstance): switch to use KDSingleApplication#9402

Open
mgallien wants to merge 4 commits intomasterfrom
feature/useKDSingleApplication
Open

feat(singleInstance): switch to use KDSingleApplication#9402
mgallien wants to merge 4 commits intomasterfrom
feature/useKDSingleApplication

Conversation

@mgallien
Copy link
Collaborator

@mgallien mgallien commented Jan 30, 2026

No description provided.

@mgallien
Copy link
Collaborator Author

mgallien commented Feb 2, 2026

will need nextcloud/desktop-client-blueprints#34

@mgallien mgallien force-pushed the feature/useKDSingleApplication branch from c22bc9f to 3c7236c Compare February 4, 2026 11:43
@mgallien mgallien mentioned this pull request Feb 4, 2026
Open
@mgallien mgallien force-pushed the feature/useKDSingleApplication branch from 3c7236c to a9462d5 Compare February 5, 2026 09:48
@Rello Rello moved this to 🏗️ In progress in 💻 Desktop Clients team Feb 5, 2026
@mgallien mgallien force-pushed the feature/useKDSingleApplication branch 2 times, most recently from 73d6eb9 to e29f764 Compare February 5, 2026 15:47
@mgallien mgallien force-pushed the feature/useKDSingleApplication branch from e29f764 to 4e39daa Compare February 6, 2026 09:23
@mgallien
Copy link
Collaborator Author

mgallien commented Feb 6, 2026

hopefully last step to fix the clang tidy workflow
nextcloud/docker-ci#894

@mgallien mgallien marked this pull request as ready for review February 6, 2026 17:17
@mgallien
chore: makes CI use the proper craft settings with all dependencies
b6f78c8 
switch to a new cache with KDSingleApplication available

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
feat(singleInstance): switch to use KDSingleApplication
7883982 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
chore: sets the python custom path for clang tidy pr action
14249a8 
pyhon version is hardcoded to 3.11 inside the action, so it cannot run
on newer distributions

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
fix(clang-tidy): use newer CI image to fix clang-tidy CI check
94baee0 
was missing pythin3-venv native package that is now included in the
newer image

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the feature/useKDSingleApplication branch from 25127f3 to 94baee0 Compare February 6, 2026 17:17
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Artifact containing the AppImage: nextcloud-appimage-pr-9402.zip

Digest: sha256:c9426cd5e7713c8589729e30aedb39877d49502e496d004fbc4820b9ee0e3447

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
24 New Code Smells (required ≤ 0)
D Maintainability Rating on New Code (required ≥ A)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio Aiiaiiio is a code owner

@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner

@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner

@nilsding nilsding Awaiting requested review from nilsding nilsding is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mgallien mgallien

Labels

None yet

Projects

💻 Desktop Clients team
Status: 🏗️ In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mgallien