Skip to content

fix(hint): explain that "--force" option exists #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oleksandr-nc wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −1
Open

fix(hint): explain that "--force" option exists #746

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
feddade
fix(hint): explain that "--force" option exists
oleksandr-nc Jan 13, 2026
3abff69
Update lib/Command/ExApp/Unregister.php
oleksandr-nc Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/Command/ExApp/Unregister.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
if ($this->dockerActions->removeExApp($this->dockerActions->buildDockerUrl($daemonConfig), $exApp->getAppid(), removeData: $rmData)) {
if (!$silent) {
$output->writeln(sprintf('Failed to remove ExApp %s', $appId));
$output->writeln('Hint: If the container was already removed manually, you can use the --force option to fullly remove it from AppAPI.');
Copy link
Collaborator

@kyteinsky kyteinsky Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing my own typo, sorry 🙈

Suggested change
$output->writeln('Hint: If the container was already removed manually, you can use the --force option to fullly remove it from AppAPI.');
$output->writeln('Hint: If the container was already removed manually, you can use the --force option to fully remove it from AppAPI.');

}
if (!$force) {
return 1;
Expand All @@ -112,12 +113,14 @@ protected function execute(InputInterface $input, OutputInterface $output): int
}
}
} else {
$containerName = $this->dockerActions->buildExAppContainerName($appId);
$removeResult = $this->dockerActions->removeContainer(
$this->dockerActions->buildDockerUrl($daemonConfig), $this->dockerActions->buildExAppContainerName($appId)
$this->dockerActions->buildDockerUrl($daemonConfig), $containerName
);
if ($removeResult) {
if (!$silent) {
$output->writeln(sprintf('Failed to remove ExApp %s container', $appId));
$output->writeln(sprintf('Hint: If the container "%s" was already removed manually, you can use the --force option to continue unregistering.', $containerName));
Copy link
Collaborator

@kyteinsky kyteinsky Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$output->writeln(sprintf('Hint: If the container "%s" was already removed manually, you can use the --force option to continue unregistering.', $containerName));
$output->writeln(sprintf('Hint: If the container "%s" was already removed manually, you can use the --force option to fully remove it from AppAPI.', $containerName));

}
if (!$force) {
return 1;
Expand Down