perf: Replace getById call with getFirstNodeById#2360
Open
CarlSchwan wants to merge 2 commits intomasterfrom
Open
perf: Replace getById call with getFirstNodeById#2360CarlSchwan wants to merge 2 commits intomasterfrom
CarlSchwan wants to merge 2 commits intomasterfrom
Conversation
And some other minor cleanup in ViewInfoCache Signed-off-by: Carl Schwan <carlschwan@kde.org>
Fix psalm when running locally Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/perf-getbyid
branch
from
1b0d7d1 to
582d517
Compare
nickvergessen
requested review from
miaulalala
and removed request for
nickvergessen
Activity
|
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
carl/perf-getbyid
|
| Run status |
|
| Run duration | 02m 21s |
| Commit |
|
| Committer | Carl Schwan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
9
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And some other minor cleanup in ViewInfoCache