Skip to content

Conversation

@jkrude
Copy link

@jkrude jkrude commented May 15, 2021

Current problem

  • Wrong permission is checked when importing an image.
  • A crash occurs after selecting a picture (instead of using the camera).
  • This results in a crash in the nextcloud-android-app too.

Suggested solution

Notes

Alternatively the permission-check could happen in the nextloud-android-app too ( in AuthentificatiorActivity), because the same permission is needed anyway later on. However, a user who only wants to use the camera would not know what for.

@tobiasKaminsky
Copy link
Collaborator

This was already done by me: blikoon#21

But unfortunately it is not yet merged in upstream :S

@jkrude
Copy link
Author

jkrude commented May 18, 2021

My bad, I should have looked more closely.
Silly question but if it wasn't merged since 2018 and causes an obvious exception in the nextcloud-android-app should it not be considered to skip the original repo?

@tobiasKaminsky
Copy link
Collaborator

should it not be considered to skip the original repo?

I assumed that original repo would merge it, as I created a PR there.
Then I forgot.
I will merge it then and include it in NC app.

@tobiasKaminsky
Copy link
Collaborator

I think this is done via #5 or?

@jkrude jkrude closed this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants