Open
Conversation
hong-sile
suggested changes
Oct 4, 2024
hong-sile
left a comment
There was a problem hiding this comment.
승훈님 수고하셨습니다!!
몇몇부분에 대한 코멘트를 남겨봤어요.
실제 자동차 경주에 대한 테스트를 어떻게 할지 고민해보면 좋을 것 같습니다.
일요일에 뵐게요!!
승훈님이 생각하기에 public으로 두면 안 좋을 것 같다는 이유는 어떤걸까요? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RacingCar 클래스는 CarRace 클래스에서만 사용되도록 하고, 외부에서는 접근하지 못하게 하고 싶어 package-private으로 지정했습니다. 그런데, package-private은 현업에서 잘 사용되지 않는다는 글들을 보게 되었습니다.
RacingCar 클래스를 public으로 두는 것이 올바르지 않다고 생각되는데, 접근 권한을 어느 수준으로 제한하는 것이 가장 바람직할까요?