Open
Conversation
|
안녕하세요 지원님! 코드리뷰를 맡게된 안정현입니다. |
|
혹시 4단계 수동 입력은 개발이 아직 안된걸까요? |
stableh
reviewed
May 8, 2024
There was a problem hiding this comment.
README가 매우 깔끔하게 작성되어 있어서 보기 좋았습니다!
어떻게 설계하시면서 코딩을 하셨는지 잘 보여진 것 같아요.
제가 배워야될 것 같습니다. 감사합니다.
Comment on lines
+19
to
+25
| private void checkValidate(String bonusNumber) { | ||
| if (!PATTERN.matcher(bonusNumber).matches()) { | ||
| throw new IllegalArgumentException("[ERROR] 올바르지 않은 입력값 입니다."); | ||
| } | ||
|
|
||
|
|
||
| } |
There was a problem hiding this comment.
mvc 패턴 중 view에 해당하는 inputView에서는 입력만 받고, 예외 처리 로직은 domain에서 작성하면 좋을 것 같습니다!
| profit += 5000* Bingo.getBingo3().correctLotto; | ||
| profit += 50000*Bingo.getBingo4().correctLotto; | ||
| profit += 1500000*Bingo.getBingo5().correctLotto; | ||
| profit += 30000000*Bingo.getBingo5wB().correctLotto; |
There was a problem hiding this comment.
"줄여 쓰지 않는다(축약 금지)"의 요구사항에 맞지 않는 것 같습니다.
w와 B가 with와 bonus를 의미한다면 풀어쓰는게 좋을 것 같습니다!
| public class CalculateProfit { | ||
| double profit = 0; | ||
|
|
||
| public void calcProfit(){ |
| private final List<Integer> numbers; | ||
|
|
||
| public Lotto(List<Integer> numbers) { | ||
| checkValidateCnt(numbers); |
| } | ||
| } | ||
|
|
||
| private void checkValidateCnt(List<Integer> numbers) { |
There was a problem hiding this comment.
outputView의 파일이 너무 잘게 나눠져 있는 것 같습니다. 하나로 합쳐서 메서드로 표현해도 되지 않을까요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.