Skip to content

fix(users): prepend https:// to external links missing protocol #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
newstler merged 1 commit into from
Feb 11, 2026
Merged

fix(users): prepend https:// to external links missing protocol #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/models/user.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,9 @@ def github_ruby_repositories_url

def social_links
links = {}
links[:website] = website if website.present?
links[:website] = ensure_protocol(website) if website.present?
links[:twitter] = "https://twitter.com/#{twitter}" if twitter.present?
links[:linkedin] = linkedin if linkedin.present?
links[:linkedin] = ensure_protocol(linkedin) if linkedin.present?
links[:github] = github_profile_url
links
end
Expand Down Expand Up @@ -245,6 +245,10 @@ def self.linkify_bio(text)

private

def ensure_protocol(url)
url.match?(%r{\A https?:// }x) ? url : "https://#{url}"
end

def precompute_bio_html
self.bio_html = self.class.linkify_bio(bio)
end
Expand Down