Skip to content

CDP neighbors: Key result on local interface, instead of remote host #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hvanderheide wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CDP neighbors: Key result on local interface, instead of remote host #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions nuts/base_tests/netmiko_cdp_neighbors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
class CdpNeighborsExtractor(AbstractHostResultExtractor):
def single_transform(self, single_result: MultiResult) -> Dict[str, Dict[str, Any]]:
neighbors = self._simple_extract(single_result)
return {neighbor["neighbor_name"]: neighbor for neighbor in neighbors}
return {neighbor["local_interface"]: neighbor for neighbor in neighbors}


class CdpNeighborsContext(NornirNutsContext):
Expand All @@ -33,25 +33,25 @@ def nuts_extractor(self) -> CdpNeighborsExtractor:
class TestNetmikoCdpNeighbors:
@pytest.mark.nuts("remote_host")
def test_remote_host(self, single_result: NutsResult, remote_host: str) -> None:
assert remote_host in single_result.result
assert any(v.get("neighbor_name") for k, v in single_result.result.items())

@pytest.mark.nuts("remote_host,local_port")
def test_local_port(
self, single_result: NutsResult, remote_host: str, local_port: str
) -> None:
assert single_result.result[remote_host]["local_interface"] == local_port
assert single_result.result[local_port]["neighbor_name"] == remote_host

@pytest.mark.nuts("remote_host,remote_port")
def test_remote_port(
self, single_result: NutsResult, remote_host: str, remote_port: str
) -> None:
assert single_result.result[remote_host]["neighbor_interface"] == remote_port
assert any(v.get("neighbor_name") == remote_host and v.get("neighbor_interface") == remote_port for k, v in single_result.result.items())

@pytest.mark.nuts("remote_host,management_ip")
def test_management_ip(
self, single_result: NutsResult, remote_host: str, management_ip: str
) -> None:
assert single_result.result[remote_host]["mgmt_address"] == management_ip
assert any(v.get("neighbor_name") == remote_host and v.get("mgmt_address") == management_ip for k, v in single_result.result.items())


class TestNetmikoCdpNeighborsCount:
Expand Down