[pull] master from jashkenas:master#40
Open
pull[bot] wants to merge 88 commits intonetorica:masterfrom
Open
Conversation
At second thought, somebody might use CVE-2021-42574 (Trojan source) or CVE-2021-42694 (homoglyph attack) in tests in order to target developers.
Remove the "xvfb" service. This is no longer used since browser testing was moved to SauceLabs. Also, for Firefox Headless or PhantomJS, Xvfb wouldn't be needed (mainly for pre-headless era of browser testing.)
Follows-up c9b4b63 and 13f71bc. Contrary to the commit message, it actually restored the older 2.6 version, and not updated to the newer QUnit 2.10 version from package.json. The oldest Node.js LTS is currently Node 12. The latest QUnit 2.18 supports Node 10+ still. This repo currently has a Node 8 CI job still. While at it, update both to 2.10.1, the last version to support Node 8, and pin it to avoid "npm install" from expanding it, and to avoid e.g. using a newer method which then fails on the website later.
Remove unneeded Xvfb from Travis config
Test: Use same QUnit version in CI as on website
ExtendScript apparently gives equal precedence to the || and && operators, so when the || appears before the &&, we need to anchor the order of evaluation with an extra pair of parentheses.
After a review comment by @captbaritone in #2953.
These expressions are nonambiguous because the && operator comes first, but eslint does not care about the order and always requires parens. I decided to go with the flow and just add those parens.
Parenthesize mixed expressions of || and &&
`npm run coveralls` implies `npm run test-node`, so the latter does not need to be run separately. This also means that `npm run lint` is skipped on Node.js 14, which is fine because it is expected to give the same result in every version of Node.js.
It is fine to run the linter and install Karma only on one version of Node.js.
add fsck error workaround to contributing.md
Fix the documentation for range step which changed behaviour in 1.10 to automatically set step to -1 if start is after stop.
fix(range): step documentation
The is DataView check relies on DataView being a constructor like it is natively. However, if an application overrides DataView from the window this ends up throwing an error when underscore is included. This here will check if DataView is the native implementation before trying to use the constructor on it. If it is not native it will fallback on the same heuristic used on older IE versions for checking if something is a DataView or not.
This includes a new module that will run about 1 out of every 3 runs that will make sure the browser DataView is replaced with an object. Without the updates to supportsDataView this would fail since stringTagBug would try to call the constructor on it.
Add nativeDataView check to isDataView
Bump GitHub workflow actions
feature/theme-toggle fixes #2909
… id, title and > symbol
Add _.VERSION to the documentation
docs: replace 'ticket' with 'issue' in contributing guidelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )