Skip to content

Add support for VLANs#497

Open
DavideRutigliano wants to merge 1 commit intonetbox-community:mainfrom
DavideRutigliano:feature/vlan-claim
Open

Add support for VLANs#497
DavideRutigliano wants to merge 1 commit intonetbox-community:mainfrom
DavideRutigliano:feature/vlan-claim

Conversation

@DavideRutigliano
Copy link

No description provided.

@DavideRutigliano DavideRutigliano changed the title Add support for VLANs and VLANGroups Add support for VLANs Jan 19, 2026
@drutigliano19 drutigliano19 force-pushed the feature/vlan-claim branch 6 times, most recently from 377f89d to 0ba2481 Compare January 20, 2026 16:22
@bruelea
Copy link
Collaborator

bruelea commented Jan 22, 2026

Hi @DavideRutigliano

Thanks for opening this PR to add support for the vlan model to the NetBox Operator.

I'd suggest to add some e2e tests and to edit the samples so that they can directly be used with the test data of the local setup created by the 'create-kind' command of the make file.

For the vlan model what's the difference between the vlan CR and the vlanclaim CR? Is it the vlanId which will be claimed dynamically by the vlanclaim controller?

@DavideRutigliano DavideRutigliano marked this pull request as draft January 22, 2026 17:01
@DavideRutigliano
Copy link
Author

DavideRutigliano commented Jan 22, 2026

Hi @bruelea

I'd suggest to add some e2e tests and to edit the samples so that they can directly be used with the test data of the local setup created by the 'create-kind' command of the make file.

On it!

For the vlan model what's the difference between the vlan CR and the vlanclaim CR? Is it the vlanId which will be claimed dynamically by the vlanclaim controller?

Correct, following the other models

@DavideRutigliano DavideRutigliano marked this pull request as ready for review January 26, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants