-
Notifications
You must be signed in to change notification settings - Fork 194
Add test container based on Alpine image. #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Amirouche A BOUBEKKI <hello@amirouche.dev>
ctalledo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amirouche for the contribution!
However it's missing a small part (see review comment).
| # Instructions: https://cri-o.io/ | ||
| RUN apk update && apk add cri-o | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are missing the installation of the Nestybox forked CRI-O here, as well as crictl and CNIs; similar to:
168 │ # Build and install the Nestybox CRI-O (for testing deployment of pods with sysbox (aka "sysbox pods"))
169 │ RUN apt-get update && apt-get install -y --no-install-recommends libgpgme-dev \
170 │ && mkdir -p /tmp/crio-build \
171 │ && git clone https://github.com/nestybox/cri-o.git /tmp/crio-build/cri-o \
172 │ && git -C /tmp/crio-build/cri-o checkout -b ${crio_version}-sysbox origin/${crio_version}-sysbox \
173 │ && cd /tmp/crio-build/cri-o && make binaries \
174 │ && mv /usr/bin/crio /usr/bin/crio.orig \
175 │ && cp /tmp/crio-build/cri-o/bin/crio-static /usr/bin/crio \
176 │ && rm -rf /tmp/crio-build
178 │ RUN wget https://github.com/kubernetes-sigs/cri-tools/releases/download/${crictl_version}/crictl-${crictl_version}-linux-${sys_arch}.tar.gz \
179 │ && sudo tar zxvf crictl-${crictl_version}-linux-${sys_arch}.tar.gz -C /usr/local/bin \
180 │ && rm -f crictl-${crictl_version}-linux-${sys_arch}.tar.gz
181 │
182 │ # Container CNIs (needed by CRI-O)
183 │ RUN curl -fsSL https://pkgs.k8s.io/core:/stable:/${k8s_version}/deb/Release.key | gpg --dearmor -o /etc/apt/keyrings/kubernetes-apt-keyring.gpg \
184 │ && echo "deb [signed-by=/etc/apt/keyrings/kubernetes-apt-keyring.gpg] https://pkgs.k8s.io/core:/stable:/${k8s_version}/deb/ /" | tee /etc/apt/sources.list.d/kubernetes.list \
185 │ && apt-get update \
186 │ && apt-get install kubernetes-cni
It compiles sysbox, and after configuring the host docker, and running sysbox daemons, I can do:
then login with admin/admin, then:
but
make testerrors, and among the unit tests onlymake test-mgrsucceeds.