Skip to content

fix: etcd config can't change namespace #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xxamxx wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: etcd config can't change namespace #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/config/config.etcd.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ import { NO_NAME_PROVIDE } from './config.messages';
export class EtcdConfig implements IConfig, OnModuleInit {
private readonly retryInterval = 5000;
private readonly logger = new Logger('ConfigModule');
private readonly namespace = 'nestcloud-config/';

constructor(
private readonly store: ConfigStore,
private readonly client: IEtcd,
private readonly name: string,
private readonly namespace: string = '',
) {
}

Expand Down
7 changes: 6 additions & 1 deletion packages/config/config.factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,12 @@ export class ConfigFactory {
client = new ConsulConfig(this.store, ref, this.options.name);
break;
case ETCD:
client = new EtcdConfig(this.store, ref, this.options.name);
client = new EtcdConfig(
this.store,
ref,
this.options.name,
this.options.namespace,
);
break;
case KUBERNETES:
client = new KubernetesConfig(
Expand Down