Skip to content

[BREAKING CHANGE] Add MultisigVersion Legacy and V2 #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhangsoledad merged 2 commits into from
May 28, 2025
Merged

[BREAKING CHANGE] Add MultisigVersion Legacy and V2 #695

zhangsoledad merged 2 commits into from
May 28, 2025

Conversation

@eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Apr 10, 2025 •
edited
Loading

This PR add MultisigVersion to ckb-sdk-java:
before

Secp256k1Blake160MultisigAllScriptHandler handler = Secp256k1Blake160MultisigAllScriptHandler();
handler.init();

This PR:

public enum MultisigVersion {
  /// Multisig Script deployed on Genesis Block
  /// https://explorer.nervos.org/script/0x5c5069eb0857efc65e1bca0c07df34c31663b3622fd3876c876320fc9634e2a8/type
  Legacy,
  /// Latest multisig script, Enhance multisig handling for optional since value
  /// https://github.com/nervosnetwork/ckb-system-scripts/pull/99
  /// https://explorer.nervos.org/script/0x36c971b8d41fbd94aabca77dc75e826729ac98447b46f91e00796155dddb0d29/data1
  V2;


Secp256k1Blake160MultisigAllScriptHandler handler = Secp256k1Blake160MultisigAllScriptHandler(MultisigVersion::Legacy);
handler.init();

Invite @doitian, @zhangsoledad, @driftluo , @quake to review.

@eval-exec eval-exec force-pushed the exec/fix-multisig branch from 020b872 to 660f1d6 Compare May 19, 2025 03:51
@eval-exec eval-exec marked this pull request as ready for review May 20, 2025 04:38
@eval-exec eval-exec force-pushed the exec/fix-multisig branch from 660f1d6 to 232193e Compare May 20, 2025 04:45
@eval-exec eval-exec mentioned this pull request May 20, 2025
Merged
@eval-exec eval-exec changed the title Update MULTISIG_TYPE_HASH, https://github.com/nervosnetwork/ckb-system-scripts/pull/98 Add MultisigVersion May 20, 2025
@eval-exec eval-exec force-pushed the exec/fix-multisig branch from 232193e to b01fdfb Compare May 22, 2025 04:12
@eval-exec eval-exec changed the title Add MultisigVersion [BREAKING CHANGE] Add MultisigVersion Legacy and V2 May 22, 2025
@eval-exec eval-exec force-pushed the exec/fix-multisig branch 2 times, most recently from 92999c4 to 622a0f7 Compare May 26, 2025 07:24
@eval-exec
Update Multisig
81ab4f1 
Signed-off-by: Eval EXEC <execvy@gmail.com>
@eval-exec eval-exec force-pushed the exec/fix-multisig branch 3 times, most recently from f2c4fb5 to 435863a Compare May 26, 2025 13:32
@eval-exec eval-exec force-pushed the exec/fix-multisig branch from 435863a to ff79d2e Compare May 27, 2025 01:33
@eval-exec
Secp256k1Blake160MultisigAllScriptHandler check multiisgVersion in ru…
c0d8bdc 
…ntime

Signed-off-by: Eval EXEC <execvy@gmail.com>
@eval-exec eval-exec force-pushed the exec/fix-multisig branch from ff79d2e to c0d8bdc Compare May 27, 2025 03:02
@zhangsoledad zhangsoledad merged commit 6532548 into nervosnetwork:master May 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quake quake quake approved these changes

@zhangsoledad zhangsoledad zhangsoledad approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eval-exec @quake @zhangsoledad