-
Notifications
You must be signed in to change notification settings - Fork 82
ABAC SHOW AUTH RULES #2827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
ABAC SHOW AUTH RULES #2827
Conversation
…d-access-control.adoc
phil198
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks nice. A couple of minor things
| | Type | ||
|
|
||
| | name | ||
| | The name of auth rule as defined in the `CREATE` or `RENAME AUTH RULE` command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | The name of auth rule as defined in the `CREATE` or `RENAME AUTH RULE` command. | |
| | The name of the auth rule as defined in the `CREATE` or `RENAME AUTH RULE` command. |
| | STRING | ||
|
|
||
| | enabled | ||
| | Whether the auth rule is enabled or not. This column will have the value true when the auth rule is enabled, and false when it is not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | Whether the auth rule is enabled or not. This column will have the value true when the auth rule is enabled, and false when it is not. | |
| | Whether the auth rule is enabled or not. This column will have the value `true` when the auth rule is enabled, and `false` when it is not. |
Do we normally do this for booleans?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, might be nice to add something like
When an auth rule is disabled it will not be evaluated and so users cannot receive its roles
even though this is somewhat stating the obvious.
| | BOOLEAN | ||
|
|
||
| | roles | ||
| | The roles which have been granted to the auth rule via one or more `GRANT ROLE … TO AUTH RULE …` commands. This column will return null if the executing user is missing or denied the `SHOW ROLES` privilege. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | The roles which have been granted to the auth rule via one or more `GRANT ROLE … TO AUTH RULE …` commands. This column will return null if the executing user is missing or denied the `SHOW ROLES` privilege. | |
| | The roles which have been granted to the auth rule via one or more `GRANT ROLE … TO AUTH RULE …` commands. This column will return `null` if the executing user is missing or denied the `SHOW ROLES` privilege. |
Hunterness
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments 💬
modules/ROOT/pages/authentication-authorization/attribute-based-access-control.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/attribute-based-access-control.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/attribute-based-access-control.adoc
Outdated
Show resolved
Hide resolved
| == Listing auth rules | ||
|
|
||
| You can list all auth rules using the Cypher command `SHOW AUTH RULES`. | ||
| It produces a table containing a single row per auth rule with the following columns: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be nice to explicitly state that all columns are returned by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, to me it feels odd to explicitly state it, when we say it produces a table with the following columns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we point it out in general, or have labels in the table for which are default when it's a mix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
though looking at show users we don't seem to do it there 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the users and the roles pages and could not find that we state it there.
modules/ROOT/pages/authentication-authorization/attribute-based-access-control.adoc
Outdated
Show resolved
Hide resolved
| The functions, `date`, `datetime`, `localdatetime`, `localtime` and `time` are only supported when an input argument is used. | ||
| ==== | ||
|
|
||
| == Listing auth rules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want a introduced in version label for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think soo, since none of it is released yet (they are hiding behind a feature flag).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the whole page should then get the label for when it's released, makes sense
...s/authentication-authorization/dbms-administration/dbms-auth-rule-management-privileges.adoc
Outdated
Show resolved
Hide resolved
...s/authentication-authorization/dbms-administration/dbms-auth-rule-management-privileges.adoc
Outdated
Show resolved
Hide resolved
...s/authentication-authorization/dbms-administration/dbms-auth-rule-management-privileges.adoc
Outdated
Show resolved
Hide resolved
...s/authentication-authorization/dbms-administration/dbms-auth-rule-management-privileges.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Therese Magnusson <scout.therese@gmail.com>
|
This PR includes documentation updates New pages: Updated pages: |
The next part of ABAC documentation, based on top of #2728
This PR contains the documentation for the SHOW AUTH RULES command.