Skip to content

feat(eye): handle case for eye without input arguments#1471

Merged
Nelson-numerical-software merged 1 commit intomasterfrom
fix-eye-no-rhs
Oct 23, 2025
Merged

feat(eye): handle case for eye without input arguments#1471
Nelson-numerical-software merged 1 commit intomasterfrom
fix-eye-no-rhs

Conversation

@Nelson-numerical-software
Copy link
Collaborator

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for calling the eye function without any input arguments, which should return a 1×1 identity matrix (equivalent to eye(1, 1)).

  • Refactored the eyeBuiltin function to extract argument parsing logic into helper functions
  • Added test coverage for the no-argument case of eye
  • Updated the changelog to document the new functionality

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
modules/constructors_functions/builtin/cpp/eyeBuiltin.cpp Refactored into helper functions extractDestClassAndSparse and parseDimensions to support the no-argument case
modules/constructors_functions/tests/test_eye.m Added test case verifying that eye without arguments returns a 1×1 identity matrix
CHANGELOG.md Documented the new feature for eye without input arguments

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Nelson-numerical-software Nelson-numerical-software merged commit d01c8f1 into master Oct 23, 2025
24 checks passed
@Nelson-numerical-software Nelson-numerical-software deleted the fix-eye-no-rhs branch October 23, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants