fix(julia_engine): Julia 1.12 support#1464
Merged
Nelson-numerical-software merged 1 commit intomasterfrom Oct 15, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Julia 1.12 by updating the Julia engine module with improved variable passing and error handling mechanisms.
- Replaces direct variable assignment with a new helper function for setting Julia global variables
- Updates test cases to use the new
jlrunfunction signature with inline Julia code execution - Improves error handling for Julia exceptions and variable conversion failures
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/tests_manager/functions/test_run.m | Adds fail status handling when output file is missing |
| modules/julia_engine/tests/test_variables_from_nelson.m | Updates test cases to use new Julia code execution pattern |
| modules/julia_engine/tests/test_jlrun.m | Adds basic tests for the updated jlrun function |
| modules/julia_engine/src/cpp/JuliaTypesImporters.hpp | Declares new function for creating Julia global variables |
| modules/julia_engine/src/cpp/JuliaTypesImporters.cpp | Implements the new global variable creation function |
| modules/julia_engine/src/cpp/JuliaRunFile.cpp | Updates to use new variable creation method with improved error handling |
| modules/julia_engine/src/cpp/JuliaRun.cpp | Updates to use new variable creation method and fixes variable naming conflicts |
| CHANGELOG.md | Documents Julia 1.12.0 support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
3684cb3 to
3f140bb
Compare
3f140bb to
19b4116
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.