Draft
Conversation
OmarIthawi
reviewed
Mar 22, 2025
Collaborator
OmarIthawi
left a comment
OmarIthawi
left a comment
There was a problem hiding this comment.
I'll continue from here.
shadinaif
commented
Mar 24, 2025
shadinaif
commented
Mar 24, 2025
shadinaif
force-pushed
the
shadinaif/theme-designer-json
branch
6 times, most recently
from
a1a348d to
ec8aa08
Compare
shadinaif
force-pushed
the
shadinaif/theme-designer-json
branch
2 times, most recently
from
8f6c2c8 to
bd79f12
Compare
shadinaif
force-pushed
the
shadinaif/theme-designer-json
branch
from
bd79f12 to
a36b8bd
Compare
OmarIthawi
reviewed
Mar 28, 2025
| } | ||
|
|
||
| root_settings = { | ||
| "logo_image_url": "url", #-- API key: logo_url |
Collaborator
There was a problem hiding this comment.
right?
Suggested change
| "logo_image_url": "url", #-- API key: logo_url | |
| "LOGO_URL": "url", #-- API key: logo_url |
Collaborator
Author
There was a problem hiding this comment.
LOGO_URL is the global fall-back. The one per tenant config is logo_image_url. Working fine in my local
OmarIthawi
reviewed
Mar 28, 2025
| }, | ||
| }, | ||
|
|
||
| "footer": { |
Collaborator
There was a problem hiding this comment.
add dark/light style mode
Suggested change
| "footer": { | |
| "footer": { | |
| "style": "dark", |
Collaborator
Author
There was a problem hiding this comment.
will the style be applied to the footer only?
Collaborator
There was a problem hiding this comment.
will the style be applied to the footer only?
@shadinaif, I'm thinking of "template": "dark-v1" and "template": "light-v1". so we add more templates in the future as requested.
OmarIthawi
approved these changes
Apr 3, 2025
Collaborator
OmarIthawi
left a comment
OmarIthawi
left a comment
There was a problem hiding this comment.
Thanks @shadinaif and Mohamed! Looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Our internal JSON structure for the theme designer
Related Issue: