Open
Conversation
ndmitchell
reviewed
Oct 4, 2021
Owner
ndmitchell
left a comment
ndmitchell
left a comment
There was a problem hiding this comment.
Thanks - shove some docs on and I'll merge!
| liftIO $ throwIO $ CommandIOException funcName optRealCommand optUserCommand | ||
| cwd exit captured exceptionBuffer | ||
|
|
||
| data CommandIOException = |
Owner
There was a problem hiding this comment.
If we're going to export this, it ends up being part of the API, so can it have some documentation comments added to it - saying it comes from commands
Contributor
Author
There was a problem hiding this comment.
I added the documentation now.
This introduces a structured exception for the result of running an external process. By using a structured type, the build system can catch these exceptions and control how they are displayed to the user rather than relying on the default shake formatting.
mpickering
force-pushed
the
wip/structured-commandioerror
branch
from
38c0570 to
f038fbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a structured exception for the result of running an
external process. By using a structured type, the build system can catch
these exceptions and control how they are displayed to the user rather
than relying on the default shake formatting.