Skip to content

Comments

fix(get_site_data_from_NASIS_db): deduplicate results#442

Merged
brownag merged 3 commits intomasterfrom
fix441
Feb 11, 2026
Merged

fix(get_site_data_from_NASIS_db): deduplicate results#442
brownag merged 3 commits intomasterfrom
fix441

Conversation

@brownag
Copy link
Member

@brownag brownag commented Feb 11, 2026

Closes #441

Uses DISTINCT to ensure degenerate cases (most likely due to issues with snapshot databases, but technically possible due to data entry issues or in custom databases mirroring NASIS structure without NASIS controls). Makes merge() pathway used inside get_site_data_from_NASIS_db() work efficiently with data.table. Internal data.table deferred for #443

@brownag brownag self-assigned this Feb 11, 2026
@brownag brownag merged commit 472d03d into master Feb 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

non-unique results in simplifyFragmentData surface fragments leads to inefficient join condition in get_site_data_from_NASIS_db

1 participant