Use html5 template tag instead of script/div hack#71
Open
charlie-hadden wants to merge 1 commit intoncri:masterfrom
Open
Use html5 template tag instead of script/div hack#71charlie-hadden wants to merge 1 commit intoncri:masterfrom
charlie-hadden wants to merge 1 commit intoncri:masterfrom
Conversation
Owner
|
Thanks for this! I will give it a try and test it a bit when I have some time. I won't merge it with master yet because of the lack of support in IE, but we could maintain a separate branch. Or maybe better, make this optional. If you'd make using a template tag optional and use the old hackish way by default I could merge this straight away. We could have an option like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this issue on a project I'm currently working on when using ckeditor in a nested field.
This PR gets rid of the script/div hack in favour of HTML5's
<template>tag. This works well for us as we don't need to target IE, but I'm not sure how suitable you'd find it for merging upstream. The browser support isn't too great: http://caniuse.com/#feat=templateThat said, there are numerous polyfills that could be used alongside the changes here. The only thing I'd be concerned about with those is whether they block execution of any
<script>tags inside the<template>. I've not had chance to test this out yet. Perhaps it would make sense to add an option tonested_fields_forto opt-in to<template>?Also had a quick look through the open issues, and I believe it would also fix #63.