test: add integration tests with real Consul instance #27
+471
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive integration test suite that runs against a real Consul instance via Docker Compose. This validates the full election lifecycle including session management, leader failover, and tag promotion. Changes: - Add configs/integration/docker-compose.yaml with minimal Consul setup - Add internal/ballot/ballot_integration_test.go with 6 integration tests - Update CI workflow to run integration tests with Consul service container - Add Makefile with test targets (test, test-integration, etc.) - Fix releaseSession() to always clear local state even if Destroy fails Integration tests cover: - Full election cycle (session, lock, tag promotion) - Leader failover when session is destroyed - Tag promotion/demotion - Health check failure triggers demotion - Multiple instances competing for leadership - Session renewal over time 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
- Coverage 78.34% 78.25% -0.10%
==========================================
Files 4 4
Lines 471 469 -2
==========================================
- Hits 369 367 -2
Misses 82 82
Partials 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive integration test suite that validates the full election lifecycle against a real Consul instance, including session management, leader failover, and tag promotion. The changes also include a bug fix to ensure releaseSession() clears local state even if the Consul session destroy operation fails.
- Integration tests with 6 test cases covering election cycles, failover, health checks, and multi-instance scenarios
- Bug fix to
releaseSession()to always clear local state, preventing stale session references - CI automation with GitHub Actions integration job using Consul service container
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
internal/ballot/ballot_integration_test.go |
Adds 6 comprehensive integration tests with //go:build integration tag to validate election behavior against real Consul |
internal/ballot/ballot.go |
Fixes releaseSession() to clear local session state before destroying session, preventing stale references |
configs/integration/docker-compose.yaml |
Provides minimal Consul dev-mode setup with health checks for local integration testing |
Makefile |
Adds convenience targets for running unit tests, integration tests, and managing Docker Compose lifecycle |
.github/workflows/ci.yml |
Adds integration job with Consul service container to run integration tests in CI |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add defer ballot.releaseSession() to all integration tests for proper session cleanup - Simplify TestIntegration_TagPromotion to test promotion only (not the incomplete demotion scenario) - Fix Makefile test-integration target to run cleanup even on test failure 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Use setupViper consistently for both ballots in LeaderFailover test - Add clarifying comments explaining that Ballot copies config at creation time, so viper resets don't affect already-created instances 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
configs/integration/docker-compose.yaml- Minimal Consul setup for testsinternal/ballot/ballot_integration_test.go- 6 integration tests with//go:build integrationtag.github/workflows/ci.yml- Addedintegrationjob with Consul serviceMakefile- Test targets (test,test-integration,integration-up,integration-down)internal/ballot/ballot.go- FixreleaseSession()to always clear local stateIntegration Tests
TestIntegration_FullElectionCycleTestIntegration_LeaderFailoverTestIntegration_TagPromotionTestIntegration_HealthCheckFailureTestIntegration_MultipleInstancesTestIntegration_SessionRenewalTest plan
go test ./...)make test-integration)🤖 Generated with Claude Code