Add asynchronous framework to Neighb Profiles and SIT#173
Open
abombin wants to merge 10 commits intofull-stackfrom
Open
Add asynchronous framework to Neighb Profiles and SIT#173abombin wants to merge 10 commits intofull-stackfrom
abombin wants to merge 10 commits intofull-stackfrom
Conversation
djsmith17
reviewed
Nov 10, 2025
Contributor
There was a problem hiding this comment.
Can I ask why we are moving the import nidap_dashboard_lib as ndl from the top of the page to lower?
Collaborator
Author
There was a problem hiding this comment.
Sure, ndl imports NeighborhoodProfiles from neighborhood_profiles, while neighborhood_profiles imports ndl. When kept on the tope of the page, I am getting a warning about the circular import. I am not entirely sure that placing it inside of the class fully solves the issue but the warning disappears.
djsmith17
reviewed
Nov 10, 2025
Contributor
There was a problem hiding this comment.
I think this is all fine. Its hard for me to appreciate everything new that is going into the new framework.
djsmith17
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified Neighborhood profiles and spatial interaction tools to use asynchronous framework