Skip to content

Comments

Add Bank Austria#6

Open
raoulbhatia wants to merge 3 commits intonblock:masterfrom
raoulbhatia:master
Open

Add Bank Austria#6
raoulbhatia wants to merge 3 commits intonblock:masterfrom
raoulbhatia:master

Conversation

@raoulbhatia
Copy link
Contributor

No description provided.

@raoulbhatia raoulbhatia changed the title Add Bank Austria WIP: Add Bank Austria Jul 16, 2018
@raoulbhatia raoulbhatia changed the title WIP: Add Bank Austria Add Bank Austria Aug 8, 2019
@raoulbhatia
Copy link
Contributor Author

@nblock kindly review.

FYI This is my first time doing more then bugfixes in Python.

@raoulbhatia
Copy link
Contributor Author

This should be merged after #7 as #7 will ensure that Travis CI is working.

Copy link
Owner

@nblock nblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! There are just some minor nitpicks:

  • Can you add some anonymized samples/tests?
  • I merged #7, could you please rebase this PR on current master?

# 13 Empfaenger BLZ
# 14 Zahlungsgrund

mappings = {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be unused?

@nblock
Copy link
Owner

nblock commented Dec 23, 2020

Could you please provide some anonymized (and minimal) exports as currently generated by Bank Austria?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants