Improve typing file to be more accurate when using HOC#30
Open
soda0289 wants to merge 1 commit intonayaabkhan:masterfrom
Open
Improve typing file to be more accurate when using HOC#30soda0289 wants to merge 1 commit intonayaabkhan:masterfrom
soda0289 wants to merge 1 commit intonayaabkhan:masterfrom
Conversation
Current the types remove some of the props typings when using the HOC.
soda0289
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current the types remove some of the props typings when using the HOC. For example I have components that return functions instead of elements. Since children is not part of the Prop type it did not get copied over. Same thing will happen with static types as well.
I copied the types that react-redux is using which seem to work better. We could also add some tests but would need typescript installed in the repo.