Skip to content

Use a dropdown in place of a text field and fix validation #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
phargogh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use a dropdown in place of a text field and fix validation #15

phargogh wants to merge 1 commit into from

Conversation

@phargogh
Copy link
Member

@phargogh phargogh commented Nov 16, 2023

This came up on the NatCap Forum and is fixed by:

  1. Correcting the MODEL_SPEC to use the correct options for an option_string
  2. Using a dropdown instead of a text field because the content is one of a few option strings anyways.

I also added a __main__.py, which makes it easier to run within a virtualenv. So you can now launch ROOT by python -m natcap.root.

@phargogh
Correcting option string validation that was failing.
c6d17c6 
Also adding a __main__.py to make it easier to run in a venv.
@phargogh phargogh requested a review from phawthorne November 16, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phawthorne phawthorne Awaiting requested review from phawthorne

Assignees

@phargogh phargogh

@phawthorne phawthorne

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phargogh @phawthorne