Skip to content

Conversation

@chris-durbin
Copy link
Contributor

@chris-durbin chris-durbin commented Jan 30, 2026

Jira Issue ID

HARMONY-2247

Description

Fix build failure from audit. Add ignore for eslint issue.

Local Test Steps

npm run better-audit

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)
  • Harmony in a Box tested (if changes made to microservices or new dependencies added)

Summary by CodeRabbit

  • Chores
    • Added a configuration entry across multiple services to register a temporary exception with an expiry date and remediation note.
    • Updated repository code ownership to include an additional owner.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 30, 2026

📝 Walkthrough

Walkthrough

Adds a new top-level .nsprc entry "1112686" (active: true, notes: "Will fix in HARMONY-2248", expiry: "2026-06-01") to multiple repository-wide, package, and service .nsprc configuration files; also appends @flamingbear to .github/CODEOWNERS.

Changes

Cohort / File(s) Summary
Root & Package
/.nsprc, packages/util/.nsprc
Inserted vulnerability override entry "1112686" with active: true, notes: "Will fix in HARMONY-2248", expiry: "2026-06-01".
Services — cron & core
services/cron-service/.nsprc, services/harmony/.nsprc, services/query-cmr/.nsprc
Added the same "1112686" entry; adjusted surrounding JSON punctuation to accommodate the new object.
Services — runners & workers
services/service-runner/.nsprc, services/work-failer/.nsprc, services/work-scheduler/.nsprc, services/work-updater/.nsprc
Added the same "1112686" entry to each service .nsprc, converted empty {} where present into an object with the new entry.
Repo metadata
.github/CODEOWNERS
Appended @flamingbear to existing CODEOWNERS entry.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested labels

hacktoberfest-accepted

Suggested reviewers

  • indiejames
  • ygliuvt

Poem

🐰 A tiny entry I did sow,

"1112686" in a row.
Notes and expiry set with care,
Till HARMONY-2248 gets there.
Hop, patch, and nap — configuration fair.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main purpose of the changeset: fixing a build failure from an audit by adding ignore entries to .nsprc configuration files.
Description check ✅ Passed The description follows the required template with all key sections completed: Jira Issue ID, Description, Local Test Steps, and PR Acceptance Checklist with appropriate checkboxes marked.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch harmony-2247

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chris-durbin chris-durbin merged commit 5966e3d into main Jan 30, 2026
6 checks passed
@chris-durbin chris-durbin deleted the harmony-2247 branch January 30, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants