Skip to content

Conversation

@thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

  • Fixes Size variables/parameters could be updated to use the size_t type #75
    • Converts suitable variables + function parameters that represent size to the size_t type
    • Zero's out the global data struct at the beginning of initialization
    • A couple of minor fixes are added here including typos and replacing some function name text to use __func__ (to avoid potential future technical debt)

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).

System(s) tested on
Debian GNU/Linux 12 (bookworm)
Current main branch of cFS bundle.

Contributor Info
Avi Weiss   @thnkslprpt

/******************************************************************************/

bool MD_Verify32Aligned(cpuaddr Address, uint32 Size)
bool MD_Verify32Aligned(cpuaddr Address, size_t Size)

Check notice

Code scanning / CodeQL

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
/******************************************************************************/

bool MD_Verify16Aligned(cpuaddr Address, uint32 Size)
bool MD_Verify16Aligned(cpuaddr Address, size_t Size)

Check notice

Code scanning / CodeQL

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Size variables/parameters could be updated to use the size_t type

1 participant