This repository was archived by the owner on Sep 2, 2025. It is now read-only.
Conversation
Remove violent language.
|
This is not violent language. This is a generic well known English idiom with a known meaning, in this case a positive one. In fact you can search Google for "define killer" and one of the dictionary definitions that comes up is:
In fact this is the first definition for the work as used grammatically here. You seem to be conflating the noun "killer" with the adjective form for which the first most common definition is positive: https://www.merriam-webster.com/dictionary/killer The replacement suggested here is nonsensical and does not convey the same meaning. There is no reason for this change, in the context of software a "killer feature" is well understood and has no relation to violence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please don't use violent language. Use nonviolent, preferably life-affirming, language instead.