Ensure hostnames/subdomains with dots in them are displayed correctly#6
Open
jas8522 wants to merge 1 commit intonamesilo:masterfrom
Open
Ensure hostnames/subdomains with dots in them are displayed correctly#6jas8522 wants to merge 1 commit intonamesilo:masterfrom
jas8522 wants to merge 1 commit intonamesilo:masterfrom
Conversation
This ensures that subdomains of subdomains aren't cut off with just deepest subdomain showing. Example: test.test.domain.com would only show test when it should show test.test in WHMCS The most common use case for this now, is DKIM records which frequently look like: default._domainkey.theactualdomain.tld which would show as just 'default' in WHMCS until this patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that subdomains of subdomains aren't cut off with just deepest subdomain showing. Example: test.test.domain.com would only show test when it should show test.test in WHMCS
The most common use case for this now, is DKIM records which frequently look like:
default._domainkey.theactualdomain.tld
which would show as just 'default' in WHMCS until this patch.