Pagination breaks where query #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update index.js
Add pagination in app.get for Collections
…ntally discard our where filtering
…s is bad practice because load and where are both optional so we should only put them in the URL if they are actually supplied.
…s cleaner because it's clear that where is one of many optional parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After implementing pagination, I noticed that where was completely broken and after digging in the code I found it was because we weren't chaining our extra pagination filters onto the original model, thus discarding where completely.
I also improved code quality when the model is initialized.
Finally I changed the way we create the next and prev headers, they were exclude ?where in all cases and I didn't like the way the other flags like load were hardcoded in because they're optional fields.
Now the related links are built based on the supplied query.