Conversation
* Add coding conventions * Add applyTo for PHP instructions * Add extension-specific coding standards
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds Special:MobileDiff to the list of special pages blocked for anonymous users, extending the existing access control that already applies to Special:RecentChangesLinked and Special:WhatLinksHere.
Key changes:
- Updated the hook handler to block Special:MobileDiff for anonymous users
- Added comprehensive test coverage for the new blocked page
- Created test infrastructure files (stubs and composer configuration)
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| includes/Hooks.php | Added 'mobilediff' to the array of blocked special pages and updated the documentation comment |
| tests/phpunit/unit/HooksTest.php | Added test methods and data provider to verify Special:MobileDiff blocking behavior, plus infrastructure for SpecialPage class compatibility |
| tests/phpunit/stubs.php | Created basic stubs for MediaWiki constants and functions needed for testing |
| tests/phpunit/namespaced-stubs.php | Created namespaced stub classes for MediaWiki core classes to support unit testing |
| composer.json | Added PHPUnit dependency and autoload configuration for tests |
| .github/instructions/php.instructions.md | Added PHP coding conventions documentation |
| .github/instructions/mediawiki.instructions.md | Added general MediaWiki coding conventions documentation |
| .github/instructions/mediawiki-extensions.instructions.md | Added MediaWiki extension best practices documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.