Changes support deploying WTT on Debian Bookworm#92
Merged
Conversation
dracos
requested changes
May 23, 2025
Member
dracos
left a comment
dracos
left a comment
There was a problem hiding this comment.
Looks good.
Do we want to merge first+last commits (both about removing context),
and do we want to keep the deprecation disabling?
I think this is safe to remove completely. See: https://www.php.net/manual/en/migration80.incompatible.php
Quickform's data.php used curly braces for offset access; fixed. See: https://www.php.net/manual/en/migration80.incompatible.php
Member
Author
Merged the two commits in question, makes sense.
I've reverted this with a note as to why. |
Using `continue` generates a warning we're not skipping the rest of the `foreach` loop but only jumping out of the `switch` block as we would if we used `break`. To explicitly move to the next iteration of the containing loop, we should use `continue 2`. However in this case it is academic as there is no more code after the `switch`, so I'm using `break` for consistency with the rest of the code.
dracos
approved these changes
May 28, 2025
Member
dracos
left a comment
dracos
left a comment
There was a problem hiding this comment.
For merging purposes, you could drop the commit and its reversion, I guess :)
Lets you do a bit more subtle matching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.