This repository was archived by the owner on Apr 3, 2020. It is now read-only.
Code cleanup #179
Open
Code cleanup #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes refactoring slightly easier. Also calling parent constructor on presenters. Signed-off-by: Euan Torano <euantorano@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few small code cleanliness issues whilst reviewing code. This PR is a work in progress to clean some of these up. The steps are:
parent::__construct().::classprefix rather than hard coded strings. This makes working with IDEs and refactoring easier as you can jump straight to classes from Service Providers and elsewhere.There are probably other issues I'll notice and fix over time.
Signed-off-by: Euan Torano euantorano@gmail.com