Skip to content

Conversation

@jeanmw
Copy link
Collaborator

@jeanmw jeanmw commented Mar 7, 2017

hey Megan! Awesome job, you've already grown so much as a developer. Your code is clean, consistent, and the logic all makes sense.

You can expand to read more inline comments below in the commit.

A few other suggestions:

  • your functions are clean but I think you could even further reduce some of the sizes of the functions by moving repeated code out of conditionals
  • I'd say put all images in an img directory (just best practice)
  • thanks for doing a nice little README too!

overall very good job. Excited to see what you code next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants