Added support for authentication methods#115
Open
whs wants to merge 11 commits intomvisonneau:mainfrom
Open
Conversation
Author
|
Thanks for posting it here. I'm not sure if the cli has a stable public API? |
|
Actually, I'm not sure enough too 🤣 Seems like Vault CLI is using credential builtins. They are publicly available, or at least can be imported =) I think It would be way better to rewrite those builtins completely, but unfortunately it is more than I can handle on my own. Can we cooperate on this feature, how do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
--auth/VAC_AUTHto configure authentication method. Default istokenwhich is the same as existing behavior--auth-k8s-role/VAC_AUTH_K8S_ROLEto configure Kubernetes role nameeeAt this time the K8S JWT path is not configurable