Dev branch req #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renan-ua
requested changes
Feb 20, 2019
mkcli.py
Outdated
| if isUbuntu == True: | ||
| while 1: | ||
| answer = input("Java 1.8 or newer. Do you want to update it? [Y/N]: "); | ||
| if ( answer == 'Y' or answer == 'N' or answer == 'y' or answer == 'n'): |
Contributor
There was a problem hiding this comment.
I'm quite positive that if you select n, it will not exit and keep asking y/n over and over
mkcli.py
Outdated
| # response = request.urlopen(url,data) | ||
| file = response.read() | ||
| flag = False | ||
| def checkRequirements(): |
Contributor
There was a problem hiding this comment.
General comments
- you repeat the code 3 times for the packages to install.. that's bad.. please reuse and organize them as function. If we keep them as is, that means that if we add 50 packages then this code will be repeated 50 times.. that's completely wrong.
-Do not place the new code on top of the run function, I see like everything changed and cannot go through the details. - I see that the function executes even though it is not a linux based, that could be a very first verification and just skip everything
- you have no logs, no header, no nothing.
- add a flag when executing mkcli.py to bypass the verification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.