Scripts aws deploy revision #37
Open
+42
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ariana-Franco
requested review from
nilson-lagos
and removed request for
renan-ua
nilson-lagos
approved these changes
Jan 26, 2024
napoles-mk
reviewed
Jan 26, 2024
| @@ -1,8 +1,8 @@ | |||
| #!/bin/bash | |||
| sudo chmod 777 /home/ubuntu/projects/executor/gradlew | |||
| # sudo chmod 777 /home/ubuntu/projects/executor/gradlew | |||
Contributor
There was a problem hiding this comment.
Why is this change needed?
Author
There was a problem hiding this comment.
I's now needed right now, that's why I commented out.
At the first time I added this line because when trying to execute a test after the deploy it causes an error of permissions since the aws agent starts the deploy as root and the support project starts the execution as ubuntu user.
Now it's changing the owner of the executor project to ubuntu in line 3 of the deploy_scripts/config_files
napoles-mk
reviewed
Jan 26, 2024
Contributor
napoles-mk
left a comment
napoles-mk
left a comment
There was a problem hiding this comment.
Looks good, minor comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the problem and the fix.
Configuration required for the codeDeploy revision.
Added Appspec file and scripts.
Task or/and GitHub covered by this fix
https://github.com/muuklabs/support/issues/677
Tests executed
NA
Answer the following questions:
Does the PR have any dependency with BE or FE? If so, specify which PR
No
In case of a dependency, could you describe what would happen if not delivered together? (eg. FE will crash, code will not compile, etc)
NA
Did you update the extension? if that’s the case did you update the extension on remote Pupp project?
NA
Did you add a new lib package (package.json)? If so, did you update the open source spreadsheet?
NA
Did you link the defect to this PR (Github only)
Yes
If you are adding a new FE view or any significant UI change, have you shared the new UI to the team already?
NA
Did you include or update the unit tests?
NA
Did you execute the npm tests ?
NA
Did you test it in both environments (dev/prod)?
NA
if you update the routes... Did you update the sample.txt ?
NA