Modify http headers on GEB to bypass crowdsegment authentication #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem/fix:
Stepping blocks needs to bypass the authentication on crowdsegment application. For this, we need to inject some values on the http headers. To do this, we will use browsermob-core proxy.
Selenium -> browsermob-core (modify headers) -> crowsegment
https://github.com/muuklabs/prototype/issues/1366
Tests executed:
Manual Test
Questions:
Does the PR have any dependency with BE or FE?
No
In case of a dependency, could you describe what would happen if not delivered together? (eg. FE will crash, code will not compile, etc)
Functionality will not work.
Did you add a new lib package (package.json)? If so, did you update the open source spreadsheet?
No, but we need new pip3 install pymongo[srv] on the server machine.
Did you link the defect to this PR (Github only)
Yes
If you are adding a new FE view or any significant UI change, have you shared the new UI to the team already?
No new views.
Did you include or update the unit tests?
No.
Did you execute the npm tests ?
Yes
Did you test it in both environments (dev/prod)?
No, only dev.
if you update the routes... Did you update the sample.txt ?
No update to routes