Skip to content

Conversation

@jesus-serranop
Copy link

Summary of the problem/fix:
mkcli is not returning enough information when an execution fails. With this change, mkcli will return new muukReport containing step by step information (selector, part of the DOM, stepCompleted, exceptions, step type, etc).

Tests executed:
mkcli with failed and successfully test executions.

Questions:
Does the PR have any dependency with BE or FE?
Yes, BE dependencies for muukReport creation.

In case of a dependency, could you describe what would happen if not delivered together? (eg. FE will crash, code will not compile, etc)
mkcli will fail.

Did you add a new lib package (package.json)? If so, did you update the open source spreadsheet?
No

Did you link the defect to this PR (Github only)
No

If you are adding a new FE view or any significant UI change, have you shared the new UI to the team already?
No new views.

Did you include or update the unit tests?
No, changes on BE are very small, no function was updated to receive or return new parameters. Only npm test was executed.

Did you execute the npm tests ?
Yes

Did you test it in both environments (dev/prod)?
No, only dev.

if you update the routes... Did you update the sample.txt ?
No update to routes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants