-
Notifications
You must be signed in to change notification settings - Fork 0
Adding MuukReport to mkcli for a better error reporting. #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jesus-serranop
wants to merge
76
commits into
master
Choose a base branch
from
muukreport_on_mkcli
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem/fix:
mkcli is not returning enough information when an execution fails. With this change, mkcli will return new muukReport containing step by step information (selector, part of the DOM, stepCompleted, exceptions, step type, etc).
Tests executed:
mkcli with failed and successfully test executions.
Questions:
Does the PR have any dependency with BE or FE?
Yes, BE dependencies for muukReport creation.
In case of a dependency, could you describe what would happen if not delivered together? (eg. FE will crash, code will not compile, etc)
mkcli will fail.
Did you add a new lib package (package.json)? If so, did you update the open source spreadsheet?
No
Did you link the defect to this PR (Github only)
No
If you are adding a new FE view or any significant UI change, have you shared the new UI to the team already?
No new views.
Did you include or update the unit tests?
No, changes on BE are very small, no function was updated to receive or return new parameters. Only npm test was executed.
Did you execute the npm tests ?
Yes
Did you test it in both environments (dev/prod)?
No, only dev.
if you update the routes... Did you update the sample.txt ?
No update to routes