Refactor save config #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These comments can be referenced by godocs in the future.
Start of work to remove code from main(). Also making some default const if they are using in other files.
C was only used in a single function and doesn't need to be exported
It was only being reference in a function that was not being called.
Not the ideal place but gets the code out of main()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly linting
config.goand getting myself familiar with the code base. Improving how configuration variables are used will make it easier to compartmentalize the other functions into internal modules.configInitsaveTempFileI generated a few contact sheets but I don't have a comprehensive test suite. That might be the next thing I work on.