Add adaptive time stepping to elastic sims via enum in Variable #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoDeGusem
approved these changes
Jan 21, 2025
Collaborator
Author
|
Some todo's I should not forget:
|
lamoreel
requested changes
Feb 19, 2025
Contributor
lamoreel
left a comment
lamoreel
left a comment
There was a problem hiding this comment.
Definitely cleaner than the previous fix and I like this for now 👍. Still need to look at your TODOs before merging.
| def max_error(self): | ||
| """Return the maximum error per step the solver can tollerate. | ||
| def magnetization_max_error(self): | ||
| """Return the maximum error per step the solver can tollerate for the |
Contributor
There was a problem hiding this comment.
Typo: tolerate (also the two extra ones).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redo of pull request #57. The idea is exactly the same, but the implementation is different. It was easiest to start over.
Instead of using raw pointers pointing to parameters located in magnet, it uses
enum class MaxErrorinVariableto remember what error to use. The actual values of the 3 errors are now stored in the TimeSolver class, along with all other adaptive time stepping parameters. I think/hope this solution is cleaner.Still need to take a look at
sensibleTimeStep().